Conversation
This reverts commit 82061e0. This PR appears to have resulted in a substantial increase in compilation time, causing timeouts in CI for cuML PR 4029. These changes should be reinstated once the cause of the increased compilation time has been determined.
wphicks
added
bug
Contributor
|
IIRC, @mdoijade was trying to reduce compilation time (due to adding these metrics) in NVIDIA/cuml#3990? |
dantegd
requested changes
Jul 8, 2021
dantegd
left a comment
dantegd
left a comment
Contributor
There was a problem hiding this comment.
Leaving a request changes review to avoid accidental merge, this PR should not be necessary after cuml/3990
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 82061e0. PR 276 appears to have resulted in a substantial increase in compilation time, causing timeouts in CI for cuML PR 4029. These changes should be reinstated once the cause of the increased compilation time has been determined. Note that this also temporarily installs an old version of
clang-formatin order to unblock changes which will allow us to support version 11.